Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli refact: package cli{support, machine, bouncer} #3199

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 28, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.4 milestone Aug 28, 2024
@mmetc mmetc requested a review from blotus August 28, 2024 11:48
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 62.68657% with 25 lines in your changes missing coverage. Please review.

Project coverage is 51.05%. Comparing base (b880df9) to head (a78b99c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clisupport/support.go 52.63% 7 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clicapi/capi.go 60.00% 5 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clilapi/lapi.go 75.00% 3 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clibouncer/bouncers.go 57.14% 3 Missing ⚠️
cmd/crowdsec-cli/climachine/machines.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
+ Coverage   51.03%   51.05%   +0.01%     
==========================================
  Files         339      339              
  Lines       38641    38629      -12     
==========================================
+ Hits        19721    19722       +1     
+ Misses      16986    16971      -15     
- Partials     1934     1936       +2     
Flag Coverage Δ
bats 40.35% <73.68%> (+0.03%) ⬆️
unit-linux 34.60% <0.00%> (+0.01%) ⬆️
unit-windows 28.64% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from sabban August 29, 2024 12:00
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 0fb6468 into master Aug 29, 2024
18 checks passed
@mmetc mmetc deleted the clisupport branch August 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants